-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global pipelines page and link it to the global pipeline runs page #3509
Update global pipelines page and link it to the global pipeline runs page #3509
Conversation
Sorry I missed that in the JIRA description, but could you also update the links of |
b001727
to
84b7790
Compare
84b7790
to
23dd8c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3509 +/- ##
==========================================
+ Coverage 85.30% 85.34% +0.04%
==========================================
Files 1354 1354
Lines 31085 31102 +17
Branches 8682 8683 +1
==========================================
+ Hits 26517 26544 +27
+ Misses 4568 4558 -10
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, everything is working as expected.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just realized this one. If the user switches between tabs, will the applied pipeline version name carry over? |
@yannnz No it won't. It will record the search filters for each tab and every tab starts with an empty filter. |
RHOAIENG-15520
Description
Screen.Recording.2024-11-22.at.7.54.28.PM.mov
Added View runs in Pipeline version table and removed from kebab action. Also clicking on View schedule will redirect to runs page with pipeline version filtered.
How Has This Been Tested?
Test Impact
Added cypress tests to validate the navigation working with correct routes.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@yannnz