Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global pipelines page and link it to the global pipeline runs page #3509

Merged

Conversation

dpanshug
Copy link
Contributor

RHOAIENG-15520

Description

Screen.Recording.2024-11-22.at.7.54.28.PM.mov

Added View runs in Pipeline version table and removed from kebab action. Also clicking on View schedule will redirect to runs page with pipeline version filtered.

How Has This Been Tested?

  1. Navigate to pipeline page.
  2. Expand pipeline and click on View runs to navigate on Runs page, with filtered pipeline version.
  3. Also check the View schedule from Kebab action.

Test Impact

Added cypress tests to validate the navigation working with correct routes.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@yannnz

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and pnaik1 November 22, 2024 14:52
@DaoDaoNoCode
Copy link
Member

Sorry I missed that in the JIRA description, but could you also update the links of View runs and View schedules in the pipeline details page?

@dpanshug dpanshug force-pushed the pipeline-version-run branch 3 times, most recently from b001727 to 84b7790 Compare November 25, 2024 07:17
@dpanshug dpanshug force-pushed the pipeline-version-run branch from 84b7790 to 23dd8c2 Compare November 25, 2024 07:46
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (f0b961c) to head (23dd8c2).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
+ Coverage   85.30%   85.34%   +0.04%     
==========================================
  Files        1354     1354              
  Lines       31085    31102      +17     
  Branches     8682     8683       +1     
==========================================
+ Hits        26517    26544      +27     
+ Misses       4568     4558      -10     
Files with missing lines Coverage Δ
...pelinesDetails/pipeline/PipelineDetailsActions.tsx 97.50% <ø> (ø)
...d/src/concepts/pipelines/content/tables/columns.ts 100.00% <ø> (ø)
...tables/pipelineVersion/PipelineVersionTableRow.tsx 100.00% <100.00%> (ø)
frontend/src/routes/pipelines/runs.ts 73.56% <100.00%> (+5.66%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b961c...23dd8c2. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, everything is working as expected.
/lgtm

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bcdcc93 into opendatahub-io:main Nov 25, 2024
6 checks passed
@yannnz
Copy link

yannnz commented Nov 26, 2024

Just realized this one. If the user switches between tabs, will the applied pipeline version name carry over?

@DaoDaoNoCode
Copy link
Member

@yannnz No it won't. It will record the search filters for each tab and every tab starts with an empty filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants