Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pipeline server error on project pipelines card and tab section #3404

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 30, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-14133

Description

Updated the project pipelines card and tab, showing the same error message and actions to align it with the global pipelines page when there is an error.

Screenshot 2024-10-30 at 3 08 08 PM Screenshot 2024-10-30 at 3 07 08 PM

Also, when click on the delete button, it will bump the same deleting model to confirm whether you want to delete it or not.

Screenshot 2024-10-30 at 3 08 55 PM

How Has This Been Tested?

  1. Configure a pipeline server using an invalid data connection
  2. Wait for a few minutes
  3. Check the error states in the project details page, and check whether the error message is shown on both the pipelines card and pipelines tab section in that project
  4. Try to delete the server using the action in the alert, make sure it opens a confirmation modal before deleting

Test Impact

Added a Cypress test to verify the error state on the project details page

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from dpanshug and lucferbux October 30, 2024 19:11
@DaoDaoNoCode DaoDaoNoCode force-pushed the jira-rhoaieng-14133 branch 2 times, most recently from 42d4738 to 68ee26c Compare October 30, 2024 20:30
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@23c82ac). Learn more about missing BASE report.
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...rc/concepts/pipelines/context/PipelinesContext.tsx 72.72% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3404   +/-   ##
=======================================
  Coverage        ?   85.88%           
=======================================
  Files           ?     1338           
  Lines           ?    30133           
  Branches        ?     8277           
=======================================
  Hits            ?    25880           
  Misses          ?     4253           
  Partials        ?        0           
Files with missing lines Coverage Δ
...eens/detail/overview/trainModels/PipelinesCard.tsx 94.44% <100.00%> (ø)
...ects/screens/detail/pipelines/PipelinesSection.tsx 100.00% <100.00%> (ø)
...rc/concepts/pipelines/context/PipelinesContext.tsx 92.63% <72.72%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c82ac...68ee26c. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

code looks good.

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fdcdd51 into opendatahub-io:main Nov 4, 2024
7 checks passed
@pnaik1
Copy link
Contributor

pnaik1 commented Nov 5, 2024

@DaoDaoNoCode @Gkrumbach07 sorry I missed submitting a comment here , I had requested for a small changes (its still in pending state) :(

@@ -80,6 +84,14 @@ const PipelinesCard: React.FC = () => {
);
}

if (pipelinesServer.timedOut) {
Copy link
Contributor

@pnaik1 pnaik1 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaoDaoNoCode can you even add check for pipelinesServer.compatible?
reason: due to latest pipeline changes removal of v1 when dspVersion: v1 it will display an error here instead of displaying the deprecated warning text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants