-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show pipeline server error on project pipelines card and tab section #3404
Show pipeline server error on project pipelines card and tab section #3404
Conversation
42d4738
to
68ee26c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3404 +/- ##
=======================================
Coverage ? 85.88%
=======================================
Files ? 1338
Lines ? 30133
Branches ? 8277
=======================================
Hits ? 25880
Misses ? 4253
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
code looks good.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DaoDaoNoCode @Gkrumbach07 sorry I missed submitting a comment here , I had requested for a small changes (its still in pending state) :( |
@@ -80,6 +84,14 @@ const PipelinesCard: React.FC = () => { | |||
); | |||
} | |||
|
|||
if (pipelinesServer.timedOut) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaoDaoNoCode can you even add check for pipelinesServer.compatible
?
reason: due to latest pipeline changes removal of v1
when dspVersion: v1
it will display an error here instead of displaying the deprecated warning text
JIRA: https://issues.redhat.com/browse/RHOAIENG-14133
Description
Updated the project pipelines card and tab, showing the same error message and actions to align it with the global pipelines page when there is an error.
Also, when click on the delete button, it will bump the same deleting model to confirm whether you want to delete it or not.
How Has This Been Tested?
Test Impact
Added a Cypress test to verify the error state on the project details page
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main