Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pachyderm card logo/title change #3375

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Oct 23, 2024

Closes: RHOAIENG-10488

Description

Updates the logo and title for Pachyderm to HPE Machine Learning Data Management Software

How Has This Been Tested?

Tested locally
To test on your cluster:
oc login ...
oc project opendatahub
oc apply -f manifests/rhoai/shared/apps/pachyderm/pachyderm-app.yaml
It might take a minute or so to load the changes

Test Impact

No new tests added

Screenshots

Before:
Screenshot 2024-10-23 at 12 05 03 PM
After:
Screenshot 2024-10-23 at 1 47 37 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (3f41512) to head (65d73be).
Report is 34 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
+ Coverage   84.79%   85.02%   +0.23%     
==========================================
  Files        1315     1329      +14     
  Lines       29494    29930     +436     
  Branches     8059     8206     +147     
==========================================
+ Hits        25008    25449     +441     
+ Misses       4486     4481       -5     

see 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f41512...65d73be. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Installed Pachyderm operator and added and enabled Pachyderm OdhApplication

Screenshot 2024-10-24 at 12 14 18 AM

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3f5fe8d into opendatahub-io:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants