Update project list view to readily show active notebooks

[jeff-phillips-18]

Closes RHOAIENG-14674

Description

PM review revealed the inability to quickly find active workbenches and the need for too many click to shutdown active workbenches. Updated the Project list view to show active workbenches in the workbenches column. Added start/stop actions to each work bench row rather than have them in the kebab menu.

How Has This Been Tested?

Navigate to the Data Science Project page.
Verify the workbench counts for stopped or active workbenches are accurate (workbenches in the starting phase are counted as active).
Expand the workbenches column for projects with active and stopped workbenches.
Verify the correct action is shown (start or stop) based on the workbench status.

Test Impact

Updated the e2e tests to check for the correct counts and actions

Screen shots

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

[christianvogt]

Changes worked well except for the case where the workbench is started or stopped from the project list page. The state never seems to transition to running or stopped. It gets stuck in starting or stopping until the page is refreshed.

[jeff-phillips-18]

@christianvogt I've updated the page to watch the notebook states (updating every 30 seconds). Also fixed an issue where the stop modal was un-cancelable.

[jgiardino]

Testing the latest updates, I see an issue on the Workbenches tab. When I click Stop for a Running or Starting workbench, I see a confirmation modal. But the status behind the modal switches to Stopping at the same time, without letting me cancel out of that action in the confirmation modal.

I don't see this issue on the Projects page.

[jeff-phillips-18]

Thanks @jgiardino. Pushed the fix.

[jgiardino]

I tested again. Overall these updates look good and I'm not able to find any issues. There is one odd behavior I noticed but cannot reproduce, where I opened a workbench that was in a Running state, but the JN didn't open, and then when I returned to ODH I saw that the Running state had changed to a Stopped state.

The first time I saw this behavior, the following message displayed

The second time I saw this behavior, the following message displayed

[jgiardino]

Reviewing the UI, it looks good. The only issue I noticed is likely the result of multiple people testing the UI at the same time.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (856e79e) to head (a0d8f9f).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...reens/projects/ProjectTableRowNotebookTableRow.tsx	75.00%	8 Missing ⚠️
frontend/src/pages/projects/notebook/utils.ts	78.57%	3 Missing ⚠️
...ects/screens/detail/notebooks/NotebookTableRow.tsx	93.75%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   84.82%   85.03%   +0.20%     
==========================================
  Files        1326     1327       +1     
  Lines       29676    29760      +84     
  Branches     8117     8146      +29     
==========================================
+ Hits        25174    25307     +133     
+ Misses       4502     4453      -49     

Files with missing lines	Coverage Δ
.../pages/projects/notebook/NotebookActionsColumn.tsx	100.00% <100.00%> (+6.25%)	⬆️
...rc/pages/projects/notebook/NotebookStateAction.tsx	100.00% <100.00%> (ø)
...rc/pages/projects/notebook/NotebookStateStatus.tsx	70.00% <100.00%> (ø)
...projects/screens/detail/notebooks/NotebookList.tsx	100.00% <100.00%> (ø)
...rc/pages/projects/screens/detail/notebooks/data.ts	100.00% <ø> (ø)
...ages/projects/screens/projects/ProjectTableRow.tsx	94.73% <100.00%> (+2.73%)	⬆️
.../screens/projects/ProjectTableRowNotebookTable.tsx	70.58% <100.00%> (ø)
...es/projects/screens/projects/notebookTableData.tsx	28.57% <ø> (ø)
.../src/pages/projects/screens/projects/tableData.tsx	100.00% <100.00%> (ø)
frontend/src/utilities/useRefreshInterval.ts	100.00% <100.00%> (ø)
... and 3 more

... and 18 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856e79e...a0d8f9f. Read the comment docs.

[kywalker-rh]

lgtm... looks and works as expected

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jgiardino, kywalker-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment