-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount path in DS projects #3315
Conversation
640c778
to
8562481
Compare
frontend/src/pages/projects/screens/detail/notebooks/NotebookStorageBars.tsx
Outdated
Show resolved
Hide resolved
Thanks @pnaik1 @DaoDaoNoCode ! LGTM! |
frontend/src/pages/projects/screens/detail/notebooks/NotebookStorageBars.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
- Coverage 84.88% 84.87% -0.01%
==========================================
Files 1309 1309
Lines 29324 29296 -28
Branches 8000 7995 -5
==========================================
- Hits 24891 24865 -26
+ Misses 4433 4431 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-426
Description
How Has This Been Tested?
Test Impact
Added cypress test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main