-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserve sort and filter when loading more experiments #3313
preserve sort and filter when loading more experiments #3313
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
+ Coverage 84.77% 84.81% +0.04%
==========================================
Files 1308 1315 +7
Lines 29251 29517 +266
Branches 7937 8060 +123
==========================================
+ Hits 24798 25036 +238
- Misses 4453 4481 +28
... and 126 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@Gkrumbach07 applying sort filter to the experiment works fine but I still get an error when search filter is applied ![]() |
f1ac39d
to
c18eb50
Compare
@pnaik1 should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works well.
Co-authored-by: jpuzz0 <96431149+jpuzz0@users.noreply.github.com>
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jpuzz0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-12843
Description
Fix experiment selector error when loading more results with active filters
This PR addresses an issue where clicking "View more" in the experiment selector would throw an error if sort or search filters were applied. The fix ensures that pagination works correctly while preserving the current filter state.
How Has This Been Tested?
Test Impact
covered by existing tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main