-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disablePipelineExperiments feature flag #3273
Remove disablePipelineExperiments feature flag #3273
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3273 +/- ##
==========================================
- Coverage 84.87% 84.84% -0.04%
==========================================
Files 1306 1306
Lines 29196 29144 -52
Branches 7885 7855 -30
==========================================
- Hits 24780 24727 -53
- Misses 4416 4417 +1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. I ran through the code live and everything checks out and the code seems straightforward. going to wait for one more review to merge
/lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: RHOAIENG-11336
Description
Remove the feature flag
disablePipelineExperiments
and the supported areaPIPELINE_EXPERIMENTS
. Make experiments always enabled.How Has This Been Tested?
Make sure all the tests are passed and the pipeline/experiments can run/navigate correctly. Make sure nothing is broken in the pipelines area.
Also, deploy this branch to a live cluster to see if anything is broken.
Test Impact
N/A, updated mock dashboard config due to API change.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main