OSSM: Add service mesh manifests overlay #1900
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the service mesh overlay to the manifests directory which make changes to odh-dashboard resources enabling service-mesh, as well as a
minimal
overlay that can be useful when developing/testing on a cluster with low resource limits (ie: CRC).This is needed for using the new version of the operator, as the v2 operator pulls manifests from the main branch of odh-dashboard rather than from the odh-manifests repo as before.
Unfortunately, due to restrictions with kustomize and patching, two patches have to be added to the base directory - please see comments in said files and
overlays/service-mesh/kustomization.yaml
for reasoning on this. Patches that are not immediately obvious are commented with reasoning.These changes should be completely unobtrusive to users not using service-mesh, as the overlays are only enabled when specified - or in our case, when service-mesh is enabled in the v2 operator, the overlay is applied by operator.
How Has This Been Tested?
This has been tested in several ways:
kustomize build manifests/overlays/service-mesh
to ensure that the manifests build correctly using this overlay.--build-arg OVERWRITE_MANIFESTS='--odh-dashboard="maistra:odh-dashboard:add-sm-overlay:manifests:odh-dashboard"'"
Test Impact
I do not believe that tests can be created to ensure this overlay - please let me know if there is some way to add tests for this.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main