Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI test to require that every input and clickable element has a unique id attribute #186

Closed
LaVLaS opened this issue Apr 20, 2022 · 2 comments
Closed

Add CI test to require that every input and clickable element has a unique id attribute #186

LaVLaS opened this issue Apr 20, 2022 · 2 comments
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc priority/normal An issue with the product; fix when possible quality An issue to improve the quality of our code -- e2e or unit test related
Milestone
CI/CD & Testing E...

Comments

@LaVLaS
Copy link
Contributor

LaVLaS commented Apr 20, 2022

Is your feature request related to a problem? Please describe.
To support automated testing of the Dashboard UI, there should be a test to required that every input and clickable element has an id attribute to ensure that it is easy to find using xpath.

Describe the solution you'd like
This id attribute name or header should be "static" and unique so that the name does not change each release can be search with relative precision when the same element appears multiple times in the page

Describe alternatives you've considered
CI test would be best so it could be run against every PR

Additional context
N/A
@LaVLaS LaVLaS added the kind/enhancement New functionality request (existing augments or new additions) label Apr 20, 2022
dlabaj pushed a commit to dlabaj/odh-dashboard that referenced this issue Apr 22, 2022
@anishasthana
Merge pull request opendatahub-io#186 from DaoDaoNoCode/search-term-t…
a3b269e 
…racking

Add event tracking to resources searching
@andrewballantyne andrewballantyne added priority/normal An issue with the product; fix when possible quality An issue to improve the quality of our code -- e2e or unit test related labels Jul 19, 2022
@andrewballantyne andrewballantyne added the infrastructure Anything non feature/* related that improves general working of the Dashboard label Aug 9, 2022
@andrewballantyne
Copy link
Member

I think this is going to be duplicated by other efforts -- but I'll add it to the milestone for now and look to clean them up together after the backlog has been trimmed.

@andrewballantyne andrewballantyne added kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc and removed kind/enhancement New functionality request (existing augments or new additions) labels May 29, 2023
@andrewballantyne
Copy link
Member

IDs will be added as needed when we write our tests. This does not need to be a stand alone issue.

@andrewballantyne andrewballantyne closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in ODH Dashboard Planning Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc priority/normal An issue with the product; fix when possible quality An issue to improve the quality of our code -- e2e or unit test related
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
CI/CD & Testing Efforts
Development

No branches or pull requests
2 participants
@LaVLaS @andrewballantyne