Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Pin kustomize version we use in our test to the particular version #682

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jstourac
Copy link
Member

Recently the kustomize test started to fail for us since the kustomize version 5.4 introduced some breaking changes for which we will need to update our manifests to be compatible. This work will be tracked in [1]. In the meantime, we should pin kustomize version in our GHA to the version that is used by the opendatahub-operator in runtime [2].

[1] https://issues.redhat.com/browse/RHOAIENG-11679
[2] https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.12/go.mod#L30-L31

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Recently the kustomize test started to fail for us since the kustomize
version 5.4 introduced some breaking changes for which we will need to
update our manifests to be compatible. This work will be tracked in [1].
In the meantime, we should pin kustomize version in our GHA to the
version that is used by the opendatahub-operator in runtime [2].

[1] https://issues.redhat.com/browse/RHOAIENG-11679
[2] https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.12/go.mod#L30-L31
@jstourac jstourac self-assigned this Aug 21, 2024
@openshift-ci openshift-ci bot requested review from dibryant and jiridanek August 21, 2024 12:28
@jstourac jstourac requested a review from caponetto August 21, 2024 12:30
@jiridanek
Copy link
Member

why is ci running rocm tests? looks like the regex in openshift ci config for it is matching too much?

/lgtm

@paulovmr
Copy link
Contributor

/lgtm

@jstourac
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/override ci/prow/images ci/prow//rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@jstourac: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow//rocm-notebooks-e2e-tests

Only the following failed contexts/checkruns were expected:

  • build
  • ci/prow/images
  • ci/prow/rocm-notebooks-e2e-tests
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/images ci/prow//rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/override ci/prow/images ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/images ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants