Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Re-enable Trivy image scan for ROCm Pytorch image #664

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

caponetto
Copy link
Contributor

Description

Re-enabling Trivy image scan for ROCm Pytorch image since the image size is optimized.

How Has This Been Tested?

Check the green CI here

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr August 6, 2024 14:11
@jiridanek
Copy link
Member

@caponetto I think we should hold on this a bit more; the image is smaller but still not small enough I think. Or is it, actually?

@caponetto
Copy link
Contributor Author

@jiridanek From my observations, it should be ok if the image is <40GB, which is now the case. I've tested it here.

@jiridanek
Copy link
Member

guess I can't argue with "green" (or blue in my case, i have colorblind theme turned on)

/lgtm

@caponetto
Copy link
Contributor Author

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@caponetto: Overrode contexts on behalf of caponetto: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@caponetto
Copy link
Contributor Author

Can we have one more lgtm? :) @jstourac @paulovmr

@jstourac
Copy link
Member

jstourac commented Aug 7, 2024

/ltgm

Thank you, @caponetto ! 🚀

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f84cf69 into opendatahub-io:main Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants