Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-4533: Add images based on Python 3.11 #659

Merged
merged 11 commits into from
Aug 16, 2024

Conversation

caponetto
Copy link
Contributor

@caponetto caponetto commented Aug 1, 2024

https://issues.redhat.com/browse/RHOAIENG-4533

Description

Add images based on Python 3.11

How Has This Been Tested?

Notebook tests plus manual sanity checks on some images. We can handle issues separately if we find them afterward.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant August 1, 2024 17:15
Makefile Outdated Show resolved Hide resolved
@jiridanek
Copy link
Member

/lgtm

these addition are not breaking the 2024a and 2023b images, so it should be harmless to add this to the branch (after the manual sanity checks are done)

@openshift-ci openshift-ci bot removed the lgtm label Aug 5, 2024
@caponetto caponetto added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 5, 2024
@jstourac
Copy link
Member

jstourac commented Aug 5, 2024

let's see the CI check, but in general:

/lgtm

@caponetto
Copy link
Contributor Author

#635 will be applied to this PR shortly.

@caponetto caponetto force-pushed the RHOAIENG-4533 branch 2 times, most recently from d91fb43 to e6d9431 Compare August 7, 2024 16:16
@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 7, 2024
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work,
some minor changes

@caponetto
Copy link
Contributor Author

caponetto commented Aug 7, 2024

Thanks @harshad16! All in 87c6b1d

@caponetto
Copy link
Contributor Author

#667 will be applied to this PR shortly.

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 12, 2024
@jstourac
Copy link
Member

/lgtm

@caponetto
Copy link
Contributor Author

@harshad16 any other request from your side?

@atheo89
Copy link
Member

atheo89 commented Aug 14, 2024

/lgtm
However, I recommend merging this PR into a feature branch instead of the main branch.
The main branch is currently in sync with the 2024a release, however these changes (python 3.11) are intended for the upcoming 2024b release. Merging directly into the main branch could disrupt the current workflow. What do you think?
@harshad16

@caponetto
Copy link
Contributor Author

caponetto commented Aug 14, 2024

@atheo89 We had that discussion last week and the conclusion is that we can merge this code to main as long as we don't touch the manifests. Do you see any issue with this approach?

@atheo89
Copy link
Member

atheo89 commented Aug 15, 2024

Thank you for the heads up! As I see better now these changes don't affect the 2024a builds, so we are good!
/lgtm

@harshad16
Copy link
Member

Merging directly into the main branch could disrupt the current workflow. What do you think?

as shared, this discussed and the conclusion was to keep them in main for consistent development.

Thank you for the work

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

jiridanek commented Aug 16, 2024

looks like I opened the PR just at the right time to do the honors
/override ci/prow/images ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/images ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 82cb2bf into opendatahub-io:main Aug 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants