-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-4533: Add images based on Python 3.11 #659
RHOAIENG-4533: Add images based on Python 3.11 #659
Conversation
/lgtm these addition are not breaking the 2024a and 2023b images, so it should be harmless to add this to the branch (after the manual sanity checks are done) |
99fcf41
to
e98ca27
Compare
0d76adf
to
f49761d
Compare
let's see the CI check, but in general: /lgtm |
f303351
to
c95d164
Compare
#635 will be applied to this PR shortly. |
d91fb43
to
e6d9431
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work,
some minor changes
jupyter/datascience/ubi9-python-3.11/kustomize/base/kustomization.yaml
Outdated
Show resolved
Hide resolved
jupyter/intel/ml/ubi9-python-3.11/kustomize/base/kustomization.yaml
Outdated
Show resolved
Hide resolved
jupyter/intel/pytorch/ubi9-python-3.11/kustomize/base/kustomization.yaml
Outdated
Show resolved
Hide resolved
jupyter/intel/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml
Outdated
Show resolved
Hide resolved
jupyter/minimal/ubi9-python-3.11/kustomize/base/kustomization.yaml
Outdated
Show resolved
Hide resolved
Thanks @harshad16! All in 87c6b1d |
#667 will be applied to this PR shortly. |
6468041
to
1b0fb86
Compare
/lgtm |
/lgtm |
@harshad16 any other request from your side? |
/lgtm |
@atheo89 We had that discussion last week and the conclusion is that we can merge this code to |
Thank you for the heads up! As I see better now these changes don't affect the 2024a builds, so we are good! |
as shared, this discussed and the conclusion was to keep them in main for consistent development. Thank you for the work /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks like I opened the PR just at the right time to do the honors |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
82cb2bf
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-4533
Description
Add images based on Python 3.11
How Has This Been Tested?
Notebook tests plus manual sanity checks on some images. We can handle issues separately if we find them afterward.
Merge criteria: