-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add kubectl kustomize
run to check our manifests definition
#545
Conversation
Skipping CI for Draft Pull Request. |
.github/workflows/code-quality.yaml
Outdated
- name: Check kustomize manifest | ||
id: kustomize-manifests | ||
run: | | ||
type kubectl || echo TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set -x
, to avoid having to write these echos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe in the future - I added also extra lines with ----
separators for better text separation visually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job runs ---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt? |
New changes are detected. LGTM label has been removed. |
Probably we can, I'm not sure what else this change will cause. But I'm not gonna do it in this PR 🙂 |
/retest |
1 similar comment
/retest |
@jstourac: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a simple check to CI to run
kubectl kustomize
so we are sure that our kustomization.yml files don't fail with an error. This should avoid issues like this in the future hopefully red-hat-data-services#253.This is tested automatically by this PR.
This should be backported to our downstream repo.
https://issues.redhat.com/browse/RHOAIENG-7886
Description
How Has This Been Tested?
Merge criteria: