-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check commit id from commit.env file for the images in params.env file #525
Conversation
Skipping CI for Draft Pull Request. |
@jstourac: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
FTR - I'm not doing any changes to the image definitions, thus the test failures above aren't relevant to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks for all the work 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This extends our current CI for checking the image references to also check the content of the commit ID we use.
https://issues.redhat.com/browse/RHOAIENG-7885
How Has This Been Tested?
Run
./ci/check-params-env.sh
Merge criteria:
This is waiting for these to be merged first: