Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit id from commit.env file for the images in params.env file #525

Merged
merged 1 commit into from
May 31, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented May 9, 2024

Description

This extends our current CI for checking the image references to also check the content of the commit ID we use.

https://issues.redhat.com/browse/RHOAIENG-7885

How Has This Been Tested?

Run ./ci/check-params-env.sh

Merge criteria:

This is waiting for these to be merged first:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented May 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jstourac jstourac marked this pull request as ready for review May 22, 2024 17:31
@openshift-ci openshift-ci bot requested review from harshad16 and rkpattnaik780 May 22, 2024 17:31
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@jstourac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-amd-c9s-python-3-9-pr-image-mirror eec8879 link true /test notebook-amd-c9s-python-3-9-pr-image-mirror
ci/prow/notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror eec8879 link true /test notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror
ci/prow/notebooks-e2e-tests 4ccbcf9 link true /test notebooks-e2e-tests
ci/prow/images 4ccbcf9 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member Author

FTR - I'm not doing any changes to the image definitions, thus the test failures above aren't relevant to this PR.

@jstourac jstourac requested review from atheo89 and removed request for rkpattnaik780 May 29, 2024 15:34
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for all the work 💯

Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit afab4cf into opendatahub-io:main May 31, 2024
2 of 5 checks passed
@jstourac jstourac deleted the checkCommitId branch May 31, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants