Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GHAs for v1.9-branch #483

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Dec 3, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-16396 (Missing GHAs)

Description

With this PR we can enable the GHAs to run also on v1.9-branch.

We need the these gha tests to run before sign off the release/sync. Currently, wasn't enabled #482

How Has This Been Tested?

Once this PR get merged, we need to close and reopen this PR #482 to check if it will take effect of the latest changes.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 requested a review from jiridanek December 3, 2024 10:55
@openshift-ci openshift-ci bot requested review from dibryant and paulovmr December 3, 2024 10:55
@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

i'm surprised, I would've expected that not specifying any branch means all branches match; but yeah, let's merge it, why not, it might even actually help; on your PR a test was running

@atheo89
Copy link
Member Author

atheo89 commented Dec 3, 2024

Thanks for the review, I will /approve it, in order to check its effect.

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0d135e6 into opendatahub-io:main Dec 3, 2024
10 checks passed
@atheo89
Copy link
Member Author

atheo89 commented Dec 3, 2024

Great that was the trick
image
#482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants