RHOAIENG-15772: tests(odh-nbc): wait for controller manager to stop before stopping envtest #463
Conversation
…efore stopping envtest
Otherwise, there will be some errors printed in the output.
It was not breaking anything, but it was unpleasant to look at.
The notebook-controller does not seem to be suffering from this.
Probably because it does not use a webhook.
Example of the error message that's prevented by this
```
2024-11-17T20:19:57+01:00 ERROR controller-runtime.certwatcher error re-reading certificate {"error": "open /var/folders/f1/3m518k5d34l72v_9nqyjzqm80000gn/T/envtest-serving-certs-737480808/tls.crt: no such file or directory"}
```
| cfg *rest.Config | ||
| cli client.Client | ||
| envTest *envtest.Environment | ||
| cfg *rest.Config |
There was a problem hiding this comment.
The linter is right, but that's issue that has been in the repo for a long time already. See here for fix
There was a problem hiding this comment.
/override "Code static analysis / golangci-lint (components/odh-notebook-controller)"
There was a problem hiding this comment.
/override "Code static analysis / golangci-lint (components/odh-notebook-controller)"
There was a problem hiding this comment.
/override "golangci-lint (components/odh-notebook-controller)"
There was a problem hiding this comment.
yeah, I rebased merged
|
/lgtm Thank you for this! |
|
/approve |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@jiridanek: Overrode contexts on behalf of jiridanek: golangci-lint (components/odh-notebook-controller) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
shouldn't you rebase first to make this work? or we can just override? |
|
I guess I'll have to do that. My reasoning was that I did not want to lose the lgtm; updated the PR now |
|
wow, the update of a PR branch with merge really shows much more cleanly in GH ui; but I'm still partial to rebases, old habits |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
adc6db1
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-15772
Relates to
Description
Otherwise, there will be some errors printed in the output. It was not breaking anything, but it was unpleasant to look at.
The notebook-controller does not seem to be suffering from this. Probably because it does not use a webhook.
Example of the error message that's prevented by this
How Has This Been Tested?
Merge criteria: