RHOAIENG-15772: tests(odh-nbc): write auditlogs from envtest tests to disk upon request #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar note as in #450 - maybe you could put some note in the readme or somewhere? Just state that this property exists, what it is for and how it can be utilized. So that anyone can see easily? 🙂 But in general /lgtm thanks! |
… disk upon request This helps with debugging because it's then possible to do e.g. ``` cat /tmp/audit.log | jq | ... ``` and investigate what happened when a test was running.
80410d7 to
754109b
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b4646e7
into
opendatahub-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15772
Description
This helps with debugging because it's then possible to do e.g.
and investigate what happened when a test was running.
How Has This Been Tested?
Works on my machine.
Merge criteria: