RHOAIENG-15741: Sync v1.9-branch branch with main branch #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…03577 [GHA] Update odh and notebook-controller with image main-3f931d2
The version 1.23 is no longer supported [1] and only releases from 1.28 - 1.31 versions are supported. Based on the [2], the OpenShift 4.13 (oldest we care about right now) is based on Kubernetes in version 1.26, so let's allign to that version. * [1] https://kubernetes.io/releases/ * [2] https://access.redhat.com/solutions/4870701
This is a followup of opendatahub-io#391 (1b2dd4f). Without this, we can see the following failure during the e2e tests execution: ``` make run-ci-e2e-tests ... GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2 go: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: invalid version: unknown revision v3/cmd/kustomize/v5.0.2 make[1]: *** [Makefile:243: kustomize] Error 1 ... ``` This caused that all e2e tests failed. After this fix, some e2e tests pass. The other seem to fail on a problem unrelated to this one.
NO-JIRA: chore(nbcs): update tooling in controller's Makefiles - kubernetes and kustomize
…y image in CREATE events" We have a better solution of blocking updates that * are initiated by the odh-notebook-controller webhook itself * that would lead to pod restart * when the notebook is in running state and there is no external update that itself causes restart This reverts commit 4a185e0.
…uld restart a running pod
… metadata value with pending-update reason also a little unittest is added
…start RHOAIENG-15335: feat(odh-nbc/webhook): don't initiate updates that would restart a running pod
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM, but this one is missing - #406 do we want to have it here also? |
Thanks for checking; I wouldn't worry about getting it now, it does not affect downstream builds anyways. Will get it the next time we sync. |
|
Okay, thanks /lgtm |
adf190d
into
opendatahub-io:v1.9-branch
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15741
v1.9-branch...opendatahub-io:kubeflow:main