Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Allow approvers from OWNERS file to run sync gha #423

Closed

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 17, 2024

This upgrade allow approvers from OWNERS file to run sync gha

Description

How Has This Been Tested?

https://github.com/atheo89/test-auth-users/actions/runs/11382115618/job/31664947802#step:3:23

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jiridanek and jstourac October 17, 2024 09:27
Copy link

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 force-pushed the allow-approvers-to-run-gha branch from 6888dd4 to 84c2133 Compare October 17, 2024 09:33
@atheo89 atheo89 requested review from harshad16 and removed request for jstourac October 17, 2024 09:43
@jiridanek
Copy link
Member

Wow, thanks for the thought!

I can't trigger the GHA with the button on https://github.com/opendatahub-io/kubeflow/actions/workflows/sync-branches-through-pr.yaml

Screenshot 2024-10-17 at 12 15 47 PM

How does the PR help with that?

@jiridanek
Copy link
Member

Furthermore, if the https://github.com/opendatahub-io/kubeflow/actions/workflows/notebook-controller-images-updater.yaml action ran before on both main and v1.9-branch, then there will always be a merge conflict and the sync action will not finish cleanly.

But that's something that can be resolved by adding few sed commands to

- name: Prepare sync branch

so that's not a problem for now.

@atheo89
Copy link
Member Author

atheo89 commented Oct 17, 2024

I can't trigger the GHA with the button on

🤦‍♀️ no idea.
FYI if you add people as collaborators, you can hit that button. Now in this case you are in a team that is called Notebook Devs. I guessed that you have the super power to hit that button.. Maybe we need to dive into the settings.

action ran before on both main and v1.9-branch, then there will always be a merge conflict and the sync action will not finish cleanly.

That is true, we should care also

@jiridanek
Copy link
Member

Still no powers, as far as I can see.

If I understand this PR correctly, I'd title it "Prevent people not in OWNERS file to run sync gha"; it's not about giving access, but about restricting access, looks to me

@atheo89
Copy link
Member Author

atheo89 commented Oct 21, 2024

This won't work since the Notebook Devs team has triage rights, for this actions needs write.
Closing this, maybe we will found another way.

@atheo89 atheo89 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants