Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync v1.9 branch from main to get the latest changes ready for rhoai-nightly #420

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NO-JIRA: fix(gha) improve robustness by checking for resource existence
Without this, the gha is flaky and may fail with

```
notebook.kubeflow.org/minimal-notebook created
Error from server (NotFound): statefulsets.apps "minimal-notebook" not found
```
  • Loading branch information
jiridanek committed Oct 16, 2024
commit ed317a73968bc94f8c552af83a48c49f30e43df0
Original file line number Diff line number Diff line change
@@ -271,6 +271,8 @@ jobs:
port: notebook-port
EOF

# wait for the statefulset to be created
timeout 100 bash -c -- 'until kubectl get statefulset minimal-notebook; do sleep 1; done'
# wait for the good result
kubectl rollout status --watch statefulset minimal-notebook
kubectl wait statefulset minimal-notebook --for=jsonpath='{.spec.replicas}'=1 --timeout=100s