Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gha to be branch version agnostic #390

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Update gha to be branch version agnostic #390

merged 1 commit into from
Sep 25, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 25, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-13322

Description

Previously the GHA had hard coded the branch version now by adding this step we can extract it from the branch-name variable.

    - name: Extract version from branch-name
      id: version
      run: |
        if [[ "${{ env.BRANCH_NAME }}" == "main" ]]; then
          VERSION="main"
        else
          VERSION=$(echo "${{ env.BRANCH_NAME }}" | sed -E 's/^v([0-9]+\.[0-9]+)-.*/\1/')
        fi
        echo "VERSION=$VERSION" >> ${GITHUB_OUTPUT}
        echo "Extracted VERSION is: $VERSION"

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2024

/cherrypick v1.7-branch

@openshift-cherrypick-robot

@atheo89: once the present PR merges, I will cherry-pick it on top of v1.7-branch in a new PR and assign it to you.

In response to this:

/cherrypick v1.7-branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89 atheo89 requested a review from harshad16 September 25, 2024 10:07
@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2024

/hold

working on the scenario that the branch name called "main"

@openshift-ci openshift-ci bot added the do-not-merge/hold Do not merge this PR label Sep 25, 2024
@atheo89 atheo89 removed the do-not-merge/hold Do not merge this PR label Sep 25, 2024
@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2024

/unhold

make it to work also with main
Ready for review

@jiridanek
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2024

/override ci/prow/odh-notebook-controller-e2e
Since we didn't affect the kbnc code in order to merge this faster

Copy link

openshift-ci bot commented Sep 25, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/odh-notebook-controller-e2e

In response to this:

/override ci/prow/odh-notebook-controller-e2e
Since we didn't affect the kbnc code in order to merge this faster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ff97776 into opendatahub-io:v1.9-branch Sep 25, 2024
9 checks passed
@openshift-cherrypick-robot

@atheo89: new pull request created: #393

In response to this:

/cherrypick v1.7-branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member Author

atheo89 commented Sep 30, 2024

/cherrypick main

@openshift-cherrypick-robot

@atheo89: new pull request created: #399

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants