Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Upgrade the x/net package v0.23.0 for the cve fix #378

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #369

/assign jiridanek

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Copy link

openshift-ci bot commented Aug 7, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member

jstourac commented Aug 13, 2024

/lgtm

The failing vulnerability check failure against the odh-notebook-controller module isn't anything new (will be fixed by #379) - on the contrary this change fixes the vulnerability check against the notebook-controller module.

@jiridanek
Copy link
Member

/approve

@jstourac
Copy link
Member

/approve

@jstourac
Copy link
Member

/override govulncheck (components/odh-notebook-controller)

Copy link

openshift-ci bot commented Aug 13, 2024

@jstourac: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • (components/odh-notebook-controller)
  • govulncheck

Only the following failed contexts/checkruns were expected:

  • govulncheck (components/odh-notebook-controller)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override govulncheck (components/odh-notebook-controller)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/override "govulncheck (components/odh-notebook-controller)"

Copy link

openshift-ci bot commented Aug 13, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: govulncheck (components/odh-notebook-controller)

In response to this:

/override "govulncheck (components/odh-notebook-controller)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/override tide

Copy link

openshift-ci bot commented Aug 13, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

@atheo89, @harshad16 can you please review and approve?

@jiridanek jiridanek requested a review from harshad16 August 13, 2024 10:06
@harshad16
Copy link
Member

/approve
Thanks for the review

@harshad16 harshad16 merged commit 1c330f5 into opendatahub-io:stable Aug 13, 2024
8 of 10 checks passed
Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [harshad16,jiridanek,jstourac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants