Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS file with adding more approvers #363

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update OWNERS file with adding more approvers #363

merged 2 commits into from
Jul 17, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Jul 9, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from dibryant and paulovmr July 9, 2024 12:16
@openshift-ci openshift-ci bot added the lgtm label Jul 9, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jul 15, 2024
@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2024
@jiridanek jiridanek requested review from harshad16 and atheo89 July 15, 2024 14:59
harshad16
harshad16 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for the PR 💯
Kudos to the team for having more approvers

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caponetto, harshad16, jiridanek, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit f88020a into opendatahub-io:v1.7-branch Jul 17, 2024
6 of 9 checks passed
@jstourac
Copy link
Member Author

Thank you for merging this, @harshad16. Shall I cherry pick this to the stable branch also or do we plan to perform a sync with more changes later on?

@harshad16
Copy link
Member

/cherry-pick stable

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@harshad16: new pull request created: #368

In response to this:

/cherry-pick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac jstourac deleted the ownersUpdate branch July 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@paulovmr paulovmr paulovmr approved these changes

@caponetto caponetto caponetto approved these changes

@jiridanek jiridanek jiridanek approved these changes

@dibryant dibryant Awaiting requested review from dibryant

@atheo89 atheo89 Awaiting requested review from atheo89

Assignees

@jiridanek jiridanek

@caponetto caponetto

@paulovmr paulovmr

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jstourac @harshad16 @openshift-cherrypick-robot @jiridanek @caponetto @paulovmr