Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-8658, RHOAIENG-8651: Update to go 1.21 and apply go mod tidy changes #349

Merged
merged 1 commit into from
Jun 25, 2024
Merged

RHOAIENG-8658, RHOAIENG-8651: Update to go 1.21 and apply go mod tidy changes #349

merged 1 commit into from
Jun 25, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jun 14, 2024 •
edited
Loading

https://issues.redhat.com/browse/RHOAIENG-8658, https://issues.redhat.com/browse/RHOAIENG-8651

Description

How Has This Been Tested?

Scale rhoai operator to 0, deploy both images by editing controller deployments, create notebook, stop notebook. Remove internal registry, create notebook, stop notebook.

Use images from ghcr.io/jiridanek/kubeflow:odh-notebook-controller_go21 and ghcr.io/jiridanek/kubeflow:notebook-controller_go21

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr June 14, 2024 13:47
@jiridanek
Copy link
Member Author

jiridanek commented Jun 14, 2024 •
edited
Loading

At some point, we will be requested to move to go 1.21. This PR is meant to try it out ahead of time. Looks like there's an OCP-CI change that needs to be done. Something like @atheo89 did in

edit: let's just do it rn,

jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
62c9767 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
@jiridanek jiridanek mentioned this pull request Jun 14, 2024
Merged
@jiridanek jiridanek self-assigned this Jun 14, 2024
@jstourac
Copy link
Member

Just to be clear - what are motivations for this version bump?
Also, do we want to truly merge this now or was this just some kind of a rehearsal for the future?
And last question - where do you call that tidy thing 😄 I suppose that it was just local call, correct?

@jiridanek
Copy link
Member Author

Yes, go mod tidy, it is like poetry lock, it updates .sum file based on .mod file.

We will need it soon. It's those emails about us needing to be on the latest version of go-toolset to get security fixes. I think it is not something urgent for 2.10, but 2.11 it will probably need to be done.

jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
a354b73 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
7e257da 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
79b473d 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
e2c996a 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 14, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
fc4c994 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 16, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
e2bd3ac 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

The order of keys in releases.latest.candidate actually matters!
@jiridanek jiridanek changed the title Update to go 1.21 and run go mod tidy Update to go 1.21 and apply go mod tidy changes Jun 18, 2024
jiridanek added a commit to jiridanek/release that referenced this pull request Jun 19, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration
d676202 
Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

CAUTION: The order of keys in releases.latest.candidate actually matters!

Inspired by this Dashboard PR

* openshift#53354 (review)
@jiridanek jiridanek requested review from harshad16 and atheo89 June 19, 2024 19:36
@jiridanek jiridanek changed the title Update to go 1.21 and apply go mod tidy changes RHOAIENG-8658, RHOAIENG-8651: Update to go 1.21 and apply go mod tidy changes Jun 24, 2024
@jiridanek jiridanek force-pushed the jd_update_to_go21 branch from 3a74bd9 to 5d397b3 Compare June 24, 2024 10:49
@atheo89
Copy link
Member

atheo89 commented Jun 24, 2024

Tested different functionalities of odh & kbfn-controller and everything works as expected.
Thank you Jiri for this upgrade!

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2024
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Jun 24, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration (#…
7a005ce 
…53232)

Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

CAUTION: The order of keys in releases.latest.candidate actually matters!

Inspired by this Dashboard PR

* #53354 (review)
@jiridanek
Copy link
Member Author

/retest

@jiridanek
Copy link
Member Author

/cherrypick stable

@openshift-cherrypick-robot
Copy link

@jiridanek: once the present PR merges, I will cherry-pick it on top of stable in a new PR and assign it to you.

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7913131 into opendatahub-io:v1.7-branch Jun 25, 2024
11 checks passed
@openshift-cherrypick-robot
Copy link

@jiridanek: new pull request created: #359

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 25, 2024
Merged
@jiridanek jiridanek deleted the jd_update_to_go21 branch June 25, 2024 09:34
cplacani pushed a commit to cplacani/release that referenced this pull request Jun 25, 2024
@jiridanek @cplacani
[ODH] Update go to version 1.21 in notebook controller configuration (o…
e458866 
…penshift#53232)

Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

CAUTION: The order of keys in releases.latest.candidate actually matters!

Inspired by this Dashboard PR

* openshift#53354 (review)
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
@jiridanek @JianLi-RH
[ODH] Update go to version 1.21 in notebook controller configuration (o…
2f3334a 
…penshift#53232)

Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

CAUTION: The order of keys in releases.latest.candidate actually matters!

Inspired by this Dashboard PR

* openshift#53354 (review)
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
@jiridanek
[ODH] Update go to version 1.21 in notebook controller configuration (o…
5c14f0c 
…penshift#53232)

Related to this PR:

* opendatahub-io/kubeflow#349

Update go to version 1.21 to fix the failing tests and ensure consistency across all environments.

CAUTION: The order of keys in releases.latest.candidate actually matters!

Inspired by this Dashboard PR

* openshift#53354 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 left review comments

@jstourac jstourac Awaiting requested review from jstourac

@paulovmr paulovmr Awaiting requested review from paulovmr

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@jiridanek jiridanek

@atheo89 atheo89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiridanek @jstourac @atheo89 @openshift-cherrypick-robot