-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-8554: Add static-checks GitHub action for go code #345
RHOAIENG-8554: Add static-checks GitHub action for go code #345
Conversation
56be1fd
to
d8045fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a small suggestion.
d8045fa
to
dd5bfb5
Compare
dd5bfb5
to
13cf64f
Compare
LGTM, thanks! The question for the vulnerability check - it is failing right now, do we intend to merge this as is even it's failing? I guess the answer is yes? |
I'd merge it failing, and then would try to quickly fix it. It should not be too hard, I hope. The govulncheck is less sensitive than snyk, it analyzes whether the vulnerable function is called and only reports of that is the case. So it should not report too many problems. If I manage to improve the integration test to actually spawn a notebook in the clusters then we would be able to merge dependency updates when the test passes. No other manual work would be necessary to verify per PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick stable |
@harshad16: new pull request created: #360 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/RHOAIENG-8554
Description
Adds static-checks GitHub action for go code
How Has This Been Tested?
See the GHA run
Merge criteria: