[RHOAIENG-5033] Odd number of arguments passed as key-value pairs for…

[jstourac]

… logging

Fix the dpanic for log in notebook controller while injecting the trusted CA bundle configuration.

https://issues.redhat.com/browse/RHOAIENG-5033

Description

How Has This Been Tested?

Following steps:

1. Install latest ODH-nightly build on your cluster
2. Create the test DS project
3. Scale down the opendatahub-operator-controller-manager Deployment in openshift-operators namespace to 0
4. Update the image referenced by odh-notebook-controller-manager Deployment to quay.io/opendatahub/odh-notebook-controller:pr-331
5. Create a nb-test workbench
6. See the odh-notebook-controller-manager pod log

{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"workbench-trusted-ca-bundle ConfigMap is not present, start creating it...","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"Created workbench-trusted-ca-bundle ConfigMap","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"Injecting trusted-ca volume and environment variables","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"Internal registry found. Will pickup the default value from image field.","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"Updating workbench-trusted-ca-bundle ConfigMap","namespace":"test","notebook":"nb-test"}
{"level":"info","ts":"2024-05-23T15:51:50Z","logger":"controllers.Notebook","msg":"Creating Network Policy","name":"nb-test-ctrl-np"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Creating Network Policy","name":"nb-test-oauth-np"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Creating Service Account","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Creating OAuth Service","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Creating OAuth Secret","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Creating Route","notebook":"nb-test","namespace":"test"}
{"level":"info","ts":"2024-05-23T15:51:51Z","logger":"controllers.Notebook","msg":"Removing reconciliation lock","notebook":"nb-test","namespace":"test"}

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[harshad16]

/lgtm
/approve
/ok-to-test

thank you for the work 💯

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

/cherrypick stable

[openshift-cherrypick-robot]

@harshad16: new pull request created: #334

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.