Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create configmap and mount for the first workbench in NS #304

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Apr 3, 2024

create config map and mount for the first workbench in NS

Description

Fixes: https://issues.redhat.com/browse/RHOAIENG-5025

This PR fixes the issue linked above.
Currently, if the workbench is the first workbench in the namespace,
it fails to setup the config map: workbench-trusted-ca-bundle
This PR would create and mount the first workbench as well.

How Has This Been Tested?

Pre-requisite: https://access.redhat.com/documentation/en-us/red_hat_openshift_ai_cloud_service/1/html/installing_and_uninstalling_openshift_ai_cloud_service/working-with-certificates_certs

  1. Deploy the PR
  2. Create a DS project and start a workbench
  3. Check for the configmap workbench-trusted-ca-bundle
  4. Verify if the workbench is mounted with values.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [x ] The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire April 3, 2024 05:08
Copy link

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

log.Info("workbench-trusted-ca-bundle ConfigMap is not present, skipping mounting of certificates.")
return nil
log.Info("workbench-trusted-ca-bundle ConfigMap is not present,start creating..")
// create the ConfigMap if it does not exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to utilize the notebook_controller.CreateNotebookCertConfigMap function for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That func createdNotebookCertConfigMap has pointer to reconciler.
as we want to handle the admission, we didn't use that func.

please do share if you feel it can be used otherwise.

@harshad16 harshad16 requested review from rkpattnaik780 and atheo89 and removed request for LaVLaS and VaishnaviHire April 4, 2024 13:05
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Co-authored-by: Jan Stourac <jstourac@redhat.com>
@harshad16
Copy link
Member Author

@rkpattnaik780 @atheo89 can you please review this PR.

@atheo89
Copy link
Member

atheo89 commented Apr 5, 2024

Tested on my end and it works as expected
/lgtm

@harshad16
Copy link
Member Author

thank you for testing and reviewing :)

@harshad16 harshad16 merged commit f788c60 into opendatahub-io:v1.7-branch Apr 5, 2024
5 of 6 checks passed
@harshad16
Copy link
Member Author

/cherry-pick stable

@openshift-cherrypick-robot

@harshad16: new pull request created: #307

In response to this:

/cherry-pick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants