-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create configmap and mount for the first workbench in NS #304
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
components/odh-notebook-controller/controllers/notebook_webhook.go
Outdated
Show resolved
Hide resolved
log.Info("workbench-trusted-ca-bundle ConfigMap is not present, skipping mounting of certificates.") | ||
return nil | ||
log.Info("workbench-trusted-ca-bundle ConfigMap is not present,start creating..") | ||
// create the ConfigMap if it does not exist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to utilize the notebook_controller.CreateNotebookCertConfigMap
function for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That func createdNotebookCertConfigMap has pointer to reconciler.
as we want to handle the admission, we didn't use that func.
please do share if you feel it can be used otherwise.
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Co-authored-by: Jan Stourac <jstourac@redhat.com>
@rkpattnaik780 @atheo89 can you please review this PR. |
Tested on my end and it works as expected |
thank you for testing and reviewing :) |
/cherry-pick stable |
@harshad16: new pull request created: #307 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
create config map and mount for the first workbench in NS
Description
Fixes: https://issues.redhat.com/browse/RHOAIENG-5025
This PR fixes the issue linked above.
Currently, if the workbench is the first workbench in the namespace,
it fails to setup the config map:
workbench-trusted-ca-bundle
This PR would create and mount the first workbench as well.
How Has This Been Tested?
Pre-requisite: https://access.redhat.com/documentation/en-us/red_hat_openshift_ai_cloud_service/1/html/installing_and_uninstalling_openshift_ai_cloud_service/working-with-certificates_certs
workbench-trusted-ca-bundle
Merge criteria: