Inject Trusted CA on Notebook CR

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-1848

Description

This PR setup odh-notebook-controller to mount the certs set by the odh-operator platform manager and removes the support for cluster proxy. Ref link: #43
OCP Doc

How Has This Been Tested?

1. Modify odh-notebook-controller deployment yaml with this image: quay.io/opendatahub/odh-notebook-controller:pr-252
2. Check if your operator DSCI that manages injection of trusted-ca bundle configmap in namepaces is set up with the following. Ref: Add Trusted Bundle Configmap to all namespaces opendatahub-operator#848 has been merged.

spec:
  trustedCABundle:
    managementState: Managed
    customCABundle: ""

If is not created the ConfigMap you may do it manually like bellow:
oc create configmap odh-trusted-ca-bundle
oc label configmap odh-trusted-ca-bundle config.openshift.io/inject-trusted-cabundle="true"

3. Create a new workbench and check if the ca-bundle has been mounted
   

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[atheo89]

/test all

[atheo89]

/test all

[rkpattnaik780]

Thanks a lot for the PR @atheo89 🎉 .
The versification steps work for me. Have dropped few questions/suggestions.

[atheo89]

Hey @VaishnaviHire , would you mind casting an eye over this PR? Since you're an OLM expert and x-kbnc dev 🙂

[harshad16]

please take a look at the suggestions
and also i tried this
harshad16@b574862

not successfully tested,
please check with other components users to get the details.

[VaishnaviHire]

Thanks for the changes @atheo89.

/lgtm

Just one question around validation https://github.com/opendatahub-io/kubeflow/pull/252/files#r1506341414

[harshad16]

require few more changes

[harshad16]

some more change required

[atheo89]

/test odh-notebook-controller-unit

[harshad16]

some minor changes

[atheo89]

/test odh-notebook-controller-e2e

[openshift-ci]

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odh-notebook-controller-e2e	36e6ea2	link	true	/test odh-notebook-controller-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[harshad16]

/lgtm
/approve

thanks for all the work 💯

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

/cherrypick stable

[openshift-cherrypick-robot]

@harshad16: #252 failed to apply on top of branch "stable":

Applying: Remove cluster proxy support
Using index info to reconstruct a base tree...
M	components/odh-notebook-controller/controllers/notebook_controller.go
M	components/odh-notebook-controller/controllers/notebook_webhook.go
Falling back to patching base and 3-way merge...
Auto-merging components/odh-notebook-controller/controllers/notebook_webhook.go
CONFLICT (content): Merge conflict in components/odh-notebook-controller/controllers/notebook_webhook.go
Auto-merging components/odh-notebook-controller/controllers/notebook_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove cluster proxy support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.