Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust go mod download as per go version 1.19 rules #242

Merged

Conversation

harshad16
Copy link
Member

Adjust go mod download as per go version 1.19 rules

Description

From go version 1.18, go mod download, doesn't download transitive dependency.

To also download source code for transitive dependencies, use go mod download all.
https://tip.golang.org/doc/go1.18
https://go.dev/ref/mod#go-mod-download

fixes:
Try:

cd components
podman build -t kfnb -f odh-notebook-controller/Dockerfile .
[2/2] STEP 5/6: COPY --from=builder /go/pkg/mod/github.com/hashicorp third_party/hashicorp
Error: building at STEP "COPY --from=builder /go/pkg/mod/github.com/hashicorp third_party/hashicorp": checking on sources under "/home/hnalla/.local/share/containers/storage/overlay/81cc48f4c808785128af9e37578c43b6edf13746082befdb569b4446047ca9ca/merged": copier: stat: "/go/pkg/mod/github.com/hashicorp": no such file or directory

How Has This Been Tested?

cd components
podman build -t kfnb -f odh-notebook-controller/Dockerfile .

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@rkpattnaik780
Copy link

/lgtm
/approve

Thanks for catching this.

@harshad16
Copy link
Member Author

thanks for the review
/approve

Copy link

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ce9be89 into opendatahub-io:v1.7-branch Jan 17, 2024
7 checks passed
@harshad16
Copy link
Member Author

/cherrypick stable

@openshift-cherrypick-robot

@harshad16: new pull request created: #249

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants