Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the manifests with the new commit 9f0db5d #201

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

harshad16
Copy link
Member

Update the manifests with the new commit 9f0db5d

Description

Update the manifests with the new commit 9f0db5d
based on the sprint 1.35.
This image updates the change to the manifests for the deployment.

How Has This Been Tested?

NA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member Author

/retest-required

@harshad16
Copy link
Member Author

/override ci/prow/odh-notebook-controller-unit
/override ci/prow/kf-notebook-controller-unit

Unit test is not required for the maintenance PR.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/kf-notebook-controller-unit, ci/prow/odh-notebook-controller-unit

In response to this:

/override ci/prow/odh-notebook-controller-unit
/override ci/prow/kf-notebook-controller-unit

Unit test is not required for the maintenance PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshad16
Copy link
Member Author

Merging to move forward.

@harshad16 harshad16 merged commit 853eb61 into opendatahub-io:v1.7-branch Oct 17, 2023
@harshad16 harshad16 deleted the update-9f0db5d branch October 24, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant