Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove skip-provider-button flag from oauth configs" #171

Conversation

harshad16
Copy link
Member

Revert "Remove skip-provider-button flag from oauth configs"
This reverts commit fb769e5.

Description

As the issue is postponed: #109
Reverting the changes in the v1.7 branch as well.

How Has This Been Tested?

NA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit de72e7f into opendatahub-io:v1.7-branch Sep 11, 2023
@harshad16 harshad16 deleted the revert-skip-provide-button-flag-v1.7 branch October 24, 2023 19:20
jiridanek pushed a commit to jiridanek/kubeflow that referenced this pull request Dec 4, 2024
…mmadiIram-patch-5

Update renovate.json for schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant