RHOAIENG-15772: tests(nbcs): use the direct (uncached) client to driv…

…e tests (#461)

This is in accordance with the recommendations in the Kubebuilder Book.
https://book.kubebuilder.io/cronjob-tutorial/writing-tests

components/notebook-controller/controllers/suite_test.go

@@ -91,7 +91,6 @@ var _ = BeforeSuite(func() {
 		Expect(err).ToNot(HaveOccurred(), "failed to run manager")
 	}()
 
-	k8sClient = k8sManager.GetClient()
 	Expect(k8sClient).ToNot(BeNil())
 
 }, 60)

components/odh-notebook-controller/controllers/suite_test.go

@@ -83,7 +83,7 @@ var _ = BeforeSuite(func() {
 	}
 	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseFlagOptions(&opts)))
 
-	// Initiliaze test environment:
+	// Initialize test environment:
 	// https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/envtest#Environment.Start
 	By("Bootstrapping test environment")
 	envTest = &envtest.Environment{
@@ -110,7 +110,7 @@ var _ = BeforeSuite(func() {
 	utilruntime.Must(netv1.AddToScheme(scheme))
 	// +kubebuilder:scaffold:scheme
 
-	// Initiliaze Kubernetes client
+	// Initialize Kubernetes client
 	cli, err = client.New(cfg, client.Options{Scheme: scheme})
 	Expect(err).NotTo(HaveOccurred())
 	Expect(cli).NotTo(BeNil())
@@ -172,7 +172,6 @@ var _ = BeforeSuite(func() {
 	}).Should(Succeed())
 
 	// Verify kubernetes client is working
-	cli = mgr.GetClient()
 	Expect(cli).ToNot(BeNil())
 
 	for _, namespace := range testNamespaces {