Externalize KF_TAG variable to dedicated file outside of the makefile

opendatahub-io · Nov 18, 2024 · d0f6d50 · d0f6d50
1 parent dfe9aaf
commit d0f6d50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/components/odh-notebook-controller/Makefile b/components/odh-notebook-controller/Makefile
@@ -1,10 +1,12 @@
 
+include makefile-vars.mk
+
 # Image URL to use all building/pushing image targets
 IMG ?= quay.io/opendatahub/odh-notebook-controller
 TAG ?= $(shell git describe --tags --always)
 
 KF_IMG ?= quay.io/opendatahub/kubeflow-notebook-controller
-KF_TAG ?= main-363bcdb
+KF_TAG ?= $(KF_TAG)
 
 CONTAINER_ENGINE ?= podman
 

diff --git a/components/odh-notebook-controller/makefile-vars.mk b/components/odh-notebook-controller/makefile-vars.mk
@@ -0,0 +1 @@
+KF_TAG ?= main-363bcdb