Skip to content

Commit

Permalink
Update kustomization to use params env and yml on kfnc and odh-kfnc
Browse files Browse the repository at this point in the history
  • Loading branch information
atheo89 committed Jul 15, 2024
1 parent e4d2c44 commit 08616ca
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,27 @@ commonLabels:
app.kubernetes.io/part-of: odh-notebook-controller
component.opendatahub.io/name: kf-notebook-controller
opendatahub.io/component: "true"
images:
- name: docker.io/kubeflownotebookswg/notebook-controller
newName: quay.io/opendatahub/kubeflow-notebook-controller
newTag: 1.7-35b81f5
configurations:
- params.yaml
configMapGenerator:
- name: kf-notebook-controller-image-parameters
env: params.env
- name: config
behavior: merge
literals:
- USE_ISTIO=false
- ADD_FSGROUP=false
generatorOptions:
disableNameSuffixHash: true
patchesStrategicMerge:
- remove_namespace_patch.yaml
- manager_openshift_patch.yaml
- manager_service_openshift_patch.yaml
vars:
- name: odh-kf-notebook-controller-image
objref:
kind: ConfigMap
name: kf-notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-kf-notebook-controller-image
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odh-kf-notebook-controller-image=quay.io/opendatahub/kubeflow-notebook-controller:1.7-35b81f5
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
varReference:
- path: spec/template/spec/containers/image
kind: Deployment
19 changes: 15 additions & 4 deletions components/odh-notebook-controller/config/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,18 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../default
images:
- name: quay.io/opendatahub/odh-notebook-controller
newName: quay.io/opendatahub/odh-notebook-controller
newTag: 1.7-35b81f5

configMapGenerator:
- name: odh-notebook-controller-image-parameters
env: params.env
generatorOptions:
disableNameSuffixHash: true

vars:
- name: odh-notebook-controller-image
objref:
kind: ConfigMap
name: odh-notebook-controller-image-parameters
apiVersion: v1
fieldref:
fieldpath: data.odh-notebook-controller-image
1 change: 1 addition & 0 deletions components/odh-notebook-controller/config/base/params.env
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odh-notebook-controller-image=quay.io/opendatahub/odh-notebook-controller:1.7-35b81f5

0 comments on commit 08616ca

Please sign in to comment.