Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go.mod package versions #203

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

VaniHaripriya
Copy link

Description of your changes:

Resolves : RHOAIENG-7310

Implemented fixes on my fork and imported in my personal snyk account and made sure CVE is eliminated.

Checklist:

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the package update doesn't affect any other dependencies.

/lgtm

@@ -143,6 +143,7 @@ require (
)

replace (
github.com/go-git/go-git/v5 v5.4.2 => github.com/go-git/go-git/v5 v5.11.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @VaniHaripriya question:

the jira that this links to here

identifies this package: github.com/gobuffalo/packr
which is different, and the suggested fix seems to be on the packr package as well,

why is go-git updated here instead?

Copy link
Member

@DharmitD DharmitD Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR resolves this jira
Points to the go-git package, which is being updated here.

@HumairAK HumairAK merged commit fb56bf4 into opendatahub-io:master Jun 26, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants