Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logs and event collection on integration test failures #747

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Nov 13, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-15408

Description of your changes:

This PR improves troubleshooting of integration tests by adding logs and event collection on failures

Testing instructions

See how logs are shown in https://github.com/opendatahub-io/data-science-pipelines-operator/actions/runs/11843866900/job/33005780225?pr=747#step:6:1

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro changed the title WIP - Collect events and logs Added logs and event collection on integration test failures Nov 14, 2024
@hbelmiro hbelmiro marked this pull request as ready for review November 14, 2024 20:14
@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6209cac into opendatahub-io:main Nov 14, 2024
6 checks passed
@hbelmiro hbelmiro deleted the logs-its branch January 3, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants