Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick package updates & ca bundle injection. #524

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Jan 2, 2024

gmfrasca and others added 4 commits January 2, 2024 13:19
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This change will allow users to specify a configmap that contains a ca
bundle. This ca bundle is injected into the api server pod.
@openshift-ci openshift-ci bot requested review from DharmitD and harshad16 January 2, 2024 19:10
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-524
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/524/head
git checkout -b pullrequest e874fa4bf88a39ac3e232715b24a4e8a03eb24b8
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-524"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-524

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-524

@HumairAK
Copy link
Contributor Author

HumairAK commented Jan 2, 2024

Ignoring pre-comit ci failure as it's not relevant for this patch.

@HumairAK HumairAK merged commit 961edf9 into opendatahub-io:v1.5.x Jan 2, 2024
5 of 7 checks passed
@HumairAK HumairAK changed the title V1.5.x Cherry Pick package updates & ca bundle injection. Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants