Print if REGISTRY_ADDRESS is not defined

opendatahub-io · Nov 18, 2024 · 0a4c31f · 0a4c31f
1 parent 6209cac
commit 0a4c31f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/scripts/tests/collect_logs.sh b/.github/scripts/tests/collect_logs.sh
@@ -30,7 +30,7 @@ function display_pod_info {
     local NAMESPACE=$1
     local POD_NAMES
 
-    POD_NAMES=$(kubectl -n "${DSPA_NS}" get pods -o custom-columns=":metadata.name")
+    POD_NAMES=$(kubectl -n "${DSPA_NS}" get pods -o custom-columns=":metadata.name" --field-selector=status.phase=Failed)
 
     if [[ -z "${POD_NAMES}" ]]; then
         echo "No pods found in namespace '${NAMESPACE}'."

diff --git a/.github/scripts/tests/tests.sh b/.github/scripts/tests/tests.sh
@@ -31,7 +31,10 @@ ENDPOINT_TYPE="service"
 
 get_dspo_image() {
   if [ "$REGISTRY_ADDRESS" = "" ]; then
-  echo "REGISTRY_ADDRESS variable not defined." && exit 1
+    # this function is called by `IMG=$(get_dspo_image)` that captures the standard output of get_dspo_image
+    set -x
+    echo "REGISTRY_ADDRESS variable not defined."
+    exit 1
   fi
   local image="${REGISTRY_ADDRESS}/data-science-pipelines-operator"
   echo $image