-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convolutional deep neural network module #265
Conversation
Some changes in API. Caffe source files was cleared from unnecessary code.
Conflicts: modules/dnn/include/opencv2/dnn.hpp
Added wrappers for basic layers.
… classification example from GTSRB into tests.
Hi! Generally you shouldn't fail whole OpenCV build if some requirements are missing for module (at first it is needed for other users who uses opencv_contrib). In this case you should simply skip module build with optional message. Use something like this: BTW, This patch is rather big, about 5.5Mb, but I believe it is not very critical. Most part is the @vpisarev We can think about installation of the |
@vpisarev We will have the same problem of the libprotobuf and probably glog gflag dependency on the other DNN project. Then we will put caffe dependency with minimal cmake flag activated in a submodule if you think that will be buildable on buildbot servers. Probably this could help https://github.com/xdbr/cmake-module-submodule.cmake |
Header for sampe too |
@ludv1x, could you please also fix the error reported by the doc builder? |
👍 Buildbot failures are not related to DNN module |
@ludv1x Please recreate PR with "dnn" branch name (same as the extra PR branch name). Also please squash/replace commits into one (102 commits are too much and there are many useless/nonworking intermediate changes) |
If you have some problems (there are many "merge" commits from master, squashing will not go well) I prepared a sample squashed commit: c94fdef You can get it via:
|
@ludv1x The branch should match opencv_extra brach so that buildbot could test them jointly. |
This PR moves to #362 |
libprotobuf required to sucessfuly buid this module