Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convolutional deep neural network module #265

Closed
wants to merge 103 commits into from
Closed

Conversation

ludv1x
Copy link
Contributor

@ludv1x ludv1x commented Jun 16, 2015

libprotobuf required to sucessfuly buid this module

@alalek
Copy link
Member

alalek commented Jun 18, 2015

Hi!

Generally you shouldn't fail whole OpenCV build if some requirements are missing for module (at first it is needed for other users who uses opencv_contrib). In this case you should simply skip module build with optional message.

Use something like this:
https://github.com/Itseez/opencv/blob/48c9c24da6d8d4c432b674eae8808ee717c422c4/modules/cudev/CMakeLists.txt#L1-3

BTW, This patch is rather big, about 5.5Mb, but I believe it is not very critical. Most part is the .caffemodel file.

@vpisarev We can think about installation of the libprotobuf on a some builder to test compilation of this patch (I prefer Linux).

@bhack
Copy link

bhack commented Jun 18, 2015

@vpisarev We will have the same problem of the libprotobuf and probably glog gflag dependency on the other DNN project. Then we will put caffe dependency with minimal cmake flag activated in a submodule if you think that will be buildable on buildbot servers. Probably this could help https://github.com/xdbr/cmake-module-submodule.cmake

@bhack
Copy link

bhack commented Jun 18, 2015

/cc @mtamburrano @wangyida

@Nerei
Copy link

Nerei commented Aug 24, 2015

Header for sampe too

@vpisarev
Copy link
Contributor

@ludv1x, could you please also fix the error reported by the doc builder?
http://pullrequest.opencv.org/#/summary/contrib

@Nerei
Copy link

Nerei commented Sep 3, 2015

👍

Buildbot failures are not related to DNN module

@alalek
Copy link
Member

alalek commented Sep 3, 2015

@ludv1x Please recreate PR with "dnn" branch name (same as the extra PR branch name). Also please squash/replace commits into one (102 commits are too much and there are many useless/nonworking intermediate changes)

@alalek
Copy link
Member

alalek commented Sep 3, 2015

If you have some problems (there are many "merge" commits from master, squashing will not go well) I prepared a sample squashed commit: c94fdef

You can get it via:

git fetch https://github.com/Itseez/opencv_contrib c94fdefcfff9cc5b8300c49052f0c1eee8896f0b:dnn
git commit --amend # edit commit message
git push -f ...

@Nerei
Copy link

Nerei commented Sep 4, 2015

@ludv1x The branch should match opencv_extra brach so that buildbot could test them jointly.

@ludv1x ludv1x mentioned this pull request Sep 4, 2015
@ludv1x
Copy link
Contributor Author

ludv1x commented Sep 4, 2015

This PR moves to #362

@ludv1x ludv1x closed this Sep 4, 2015
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants