-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ibpc_tester.py #44
Conversation
Inverting scene queries passed to the estimator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion. Is the change valid for all split types?
Removed commented for-loop code
Checking |
No errors when running with val or test set. |
The new commit resolves the issue of duplicate detection entries in the generated submission file, and it is not dependent on the dataset. |
* Update ibpc_tester.py Inverting scene queries passed to the estimator. * Update ibpc_tester.py Removed commented for-loop code * record and pass only unique object ids in the requesst to the estimator process
As discussed with @vaheta, this change pertains to the inversion of the scene queries passed to the estimator.