Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ibpc_tester.py #44

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Update ibpc_tester.py #44

merged 4 commits into from
Feb 13, 2025

Conversation

veb-101
Copy link
Contributor

@veb-101 veb-101 commented Feb 12, 2025

As discussed with @vaheta, this change pertains to the inversion of the scene queries passed to the estimator.

Inverting scene queries passed to the estimator.
Copy link
Collaborator

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion. Is the change valid for all split types?

@veb-101
Copy link
Contributor Author

veb-101 commented Feb 13, 2025

Left a small suggestion. Is the change valid for all split types?

Checking

@veb-101
Copy link
Contributor Author

veb-101 commented Feb 13, 2025

No errors when running with val or test set.

@veb-101
Copy link
Contributor Author

veb-101 commented Feb 13, 2025

The new commit resolves the issue of duplicate detection entries in the generated submission file, and it is not dependent on the dataset.

@vaheta

@veb-101 veb-101 requested a review from Yadunund February 13, 2025 21:22
@vahetag vahetag self-requested a review February 13, 2025 22:18
@vahetag vahetag merged commit 979dc8c into opencv:main Feb 13, 2025
1 of 2 checks passed
AllProAi pushed a commit to AllProAi/bpc that referenced this pull request Mar 17, 2025
* Update ibpc_tester.py

Inverting scene queries passed to the estimator.

* Update ibpc_tester.py

Removed commented for-loop code

* record and pass only unique object ids in the requesst to the estimator process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants