curvefs/client: rm create fs in init #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd7524d to
c764b58
Compare
|
recheck |
5 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
e512143 to
b52da90
Compare
|
recheck |
xu-chaojie
reviewed
Jan 14, 2022
curvefs/src/client/fuse_client.cpp
Outdated
| << ", fsName = " << fsName; | ||
| return ret2; | ||
| } | ||
| LOG(ERROR) << "The fsName not exist, try to CreateFs" |
There was a problem hiding this comment.
”try to CreateFs“ is not need.
xu-chaojie
reviewed
Jan 14, 2022
| } else if (response_->statuscode() == mds::FSStatusCode::OK) { | ||
| // create success | ||
| } else if (response_->statuscode() == mds::FSStatusCode::OK || | ||
| response_->statuscode() == mds::FSStatusCode::FS_EXIST) { |
There was a problem hiding this comment.
maybe fs is truely exist, still return success?
There was a problem hiding this comment.
maybe fs is truely exist, still return success?
This is a bug that was fixed by other PRs, and I forgot to modify it here.
xu-chaojie
reviewed
Jan 14, 2022
| // create success | ||
| } else if (response_->statuscode() == mds::FSStatusCode::OK || | ||
| response_->statuscode() == mds::FSStatusCode::FS_EXIST) { | ||
| // create success or fs exist | ||
| std::cout << "create fs success." << std::endl; | ||
| } else if (response_->statuscode() == mds::FSStatusCode::FS_EXIST) { |
There was a problem hiding this comment.
if so, this branch will never be entered
There was a problem hiding this comment.
This is a bug that was fixed by other PRs, and I forgot to modify it here.
b52da90 to
57d5fad
Compare
|
recheck |
1. curvefs_tool has add create-fs 2. fix some error output
57d5fad to
0deeeb4
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
xu-chaojie
approved these changes
Jan 19, 2022
|
recheck |
|
recheck |
wu-hanqing
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #891
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List