curvefs/tool: delete-fs #1014
Merged
curvefs/tool: delete-fs #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
1 similar comment
|
recheck |
SeanHai
reviewed
Jan 20, 2022
| > | ||
| > tree: build a json tree of the current topology. | ||
| > | ||
| > Usage: |
There was a problem hiding this comment.
The default jsonType is tree?
There was a problem hiding this comment.
The default jsonType is tree?
build
curvefs/src/tools/README.md
Outdated
| > "zone": "zone1" | ||
| > }, | ||
| > { | ||
| > "externalip": "10.182.2.47", |
There was a problem hiding this comment.
Keep the ip and port same as above.
There was a problem hiding this comment.
Keep the ip and port same as above.
fix
| @@ -42,7 +42,7 @@ DEFINE_string(poolId, "1,2,3", "pools id"); | |||
| DEFINE_bool(detail, false, "show more infomation"); | |||
| DEFINE_string(partitionId, "1,2,3", "partition id"); | |||
| DEFINE_string(metaserverId, "1,2,3", "metaserver id"); | |||
| DEFINE_bool(confirm, false, "confirm execution"); | |||
| DEFINE_bool(noconfirm, false, "executed command without confirmation"); | |||
wu-hanqing
reviewed
Jan 20, 2022
curvefs/src/tools/README.md
Outdated
| > "externalport": 8902, | ||
| > "internalip": "10.182.2.48", | ||
| > "internalport": 8902, | ||
| > "name": "10.182.2.48_2_0", |
There was a problem hiding this comment.
why not display hostname?
There was a problem hiding this comment.
why not display hostname?
in server that is it's name.
6129c27 to
1c33ee6
Compare
SeanHai
approved these changes
Jan 20, 2022
1. add -noconfirm for delete-fs 2. adjust delete-fs confirm input 3. Readme fix
1c33ee6 to
af4e648
Compare
|
recheck |
wu-hanqing
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve
Issue Number: close #843
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List