-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainer updates as per #1101 #1150
Conversation
Signed-off-by: H. Vetinari <h.vetinari@gmx.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Hey folks! I wanted to chime in from the TOB here. It looks like the governance document for the runtime spec does not currently establish procedures for adding (or removing) maintainers. Under the current set of rules I can see two paths forward:
The current governance rules require a 2/3 approval for a motion to pass; with 8 current maintainers that means at least 6 must approve. (Note: the governance document recommends voting on the mailing list with a "SHOULD" but not a "MUST" so I think it'd be reasonable to go forward with 6 approvals here if the current maintainers prefer to do that.) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@samuelkarp I don't know why it's not mentioned in the governance document (the point of copy-pasting the same document was so we had rules for everything already), but adding maintainers with a 2/3rd vote is accepted practice and is covered under the general governance change rules. It would be a good idea to do a review of the governance documents for all the projects to make sure they aren't missing important information like this. I suspect this information is missing because the rules for adding maintainers in runc were outlined in the |
Gentle ping @crosbymichael @dqminh @vbatts |
☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry I missed this PR. And then came here as I'm trying to determine and refresh myself on the process for adding and removing maintainers :-\
I generally agree with maintaining the 2/3 quorum for topics like adding/removing maintainers. And hope to see (or create) a PR for this language in the specs projects soon.
For the record, with my vote it makes the 2/3 quorum for this vote. And effective upon merge we'll have 11 maintainers for an 7.3 majority? So, A) maybe we'll round that to 7?; B) perhaps some folks step down before being voted off?
congrats and welcome @AkihiroSuda, @kolyshkin, and @thaJeztah! 🧁 |
Add "recently" added runc-maintainers also to runtime spec (emails taken from runc). These 3 have a proven track record of excellent work in runc, and so I feel comfortable to propose them as one batch.
They have also all agreed in #1101 to join, see this comment and below.
If someone wants to split the PR or propose their own one, I really really don't mind - I'm just trying to get the ball rolling. 🙃
CC @AkihiroSuda
CC @kolyshkin
CC @thaJeztah
Needs at least 6 approvals from the current 8 maintainers: