Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int64 and uint64 type value ranges #1060

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix int64 and uint64 type value ranges #1060

merged 1 commit into from
Aug 5, 2020

Conversation

johnbartholomew
Copy link
Contributor

Fixes #1051, making the schema definition for 'int64' and 'uint64' types have the expected ranges:

  • int64 minimum is -2^63
  • int64 maximum is 2^63-1
  • uint64 maximum is 2^64-1

Signed-off-by: John Bartholomew jpa.bartholomew@gmail.com

@johnbartholomew
Fix int64 and uint64 type value ranges
11bfea2 
Signed-off-by: John Bartholomew <jpa.bartholomew@gmail.com>
tianon
tianon approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Confirmed that these new values match MAX_UINT64, MIN_INT64, and MAX_INT64.)

thaJeztah
thaJeztah approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

thanks for contributing!

@AkihiroSuda AkihiroSuda mentioned this pull request Aug 5, 2020
Closed
@vbatts
Copy link
Member

vbatts commented Aug 5, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 80426cc into opencontainers:master Aug 5, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Merged
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon tianon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

JSON Schema definitions of 'int64' and 'uint64' types have ranges not representable in 64 bits
5 participants
@johnbartholomew @vbatts @tianon @thaJeztah @AkihiroSuda