Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.24, drop Go 1.22 #4598

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Add Go 1.24, drop Go 1.22 #4598

merged 3 commits into from
Feb 13, 2025

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jan 21, 2025

  • CI: add Go 1.24, drop go1.22
  • Require Go 1.23.x, drop Go 1.22 support
  • .cirrus.yml: use Go 1.24

See commits for details.

@kolyshkin

This comment was marked as outdated.

@akhilerm
Copy link
Contributor

Nice, we have a problem with exec.

Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled.

@kolyshkin
Copy link
Contributor Author

Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled.

Sure.

It has been cancelled because of timeout. The timeout is happening because one of the bats tests hangs. The output from the test shows the last successful test, if you take a look at a log from a successful run you'll see the next test is runc exec --cap. When I tried the same test locally, and then I saw that in fact every test case which involves exec and has stdin is hanging in the same way.

@kolyshkin
Copy link
Contributor Author

@kolyshkin
Copy link
Contributor Author

Opened #4602 to track this for runc.

@thaJeztah
Copy link
Member

Interesting; great digging! Seems like moby may be missing a test-case for this, or at least I recall my test-PR with go 1.24rc1 completed succesfully

@kolyshkin kolyshkin changed the title [DNM] try Go 1.24 Add Go 1.24, drop Go 1.22 Feb 12, 2025
Also, bump golangci-lint to v1.64 (v1.64.2 added Go 1.24 support).

NOTE we still use Go 1.23.x for official builds.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Also:
1. Change GO_VERSION to GO_VER_PREFIX, and move the "." from the jq
   argument to the variable value. It allows to use something like
   "1.25" to match "1.25rc" etc, but set to "1.24." for now to require
   a released 1.24.x version.

2. Change PREFIX to URL_PREFIX.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin marked this pull request as ready for review February 12, 2025 16:15
@kolyshkin kolyshkin requested review from rata and lifubang February 13, 2025 08:07
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching/fixing the issue in go rc releases too!

@rata rata merged commit 20727c6 into opencontainers:main Feb 13, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants