-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.24, drop Go 1.22 #4598
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled. |
Sure. It has been cancelled because of timeout. The timeout is happening because one of the bats tests hangs. The output from the test shows the last successful test, if you take a look at a log from a successful run you'll see the next test is |
|
Opened #4602 to track this for runc. |
Interesting; great digging! Seems like moby may be missing a test-case for this, or at least I recall my test-PR with go 1.24rc1 completed succesfully |
Also, bump golangci-lint to v1.64 (v1.64.2 added Go 1.24 support). NOTE we still use Go 1.23.x for official builds. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Also: 1. Change GO_VERSION to GO_VER_PREFIX, and move the "." from the jq argument to the variable value. It allows to use something like "1.25" to match "1.25rc" etc, but set to "1.24." for now to require a released 1.24.x version. 2. Change PREFIX to URL_PREFIX. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for catching/fixing the issue in go rc releases too!
See commits for details.