ci/gha: add all-done jobs #4376
Conversation
6488daf to
9a2176c
Compare
9a2176c to
fd43c2b
Compare
|
Once this is merged, we can edit branch protection rules to mark only "ci / all-done" and "validate / all-done" tasks as required, removing all other GHA entries. This solves the issue of needing to edit branch protection rules when we switch Go versions or some such. |
|
Ah! I was considering something like this for auto-merge as well; auto-merge has the very confusing behavior to ONLY wait for required checks to complete. Any other check is simply ignored, which means that it can merge automatically if checks fail, or even didn't run at all 🙈 I wish GitHub actions had some option for this though that didn't require manually constructing the "needs" list 😞 |
There was a problem hiding this comment.
conceptually "LGTM"
happy to learn if someone would know a different approach to do the same that doesn't require manually maintaining the list (@crazy-max do you have some trick up your sleeve?)
fd43c2b to
8d88fe0
Compare
Yeah, I thought about that, too, and read this document twice, alas, couldn't find a way. |
The sole reason is to simplify branch protection rules, requiring just these to be passed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
8d88fe0 to
2cd24a4
Compare
|
Can we please merge this @opencontainers/runc-maintainers ? I really want to simplify the branch protection rules. |
|
Awesome, I've simplified branch protection rules for the main branch, now we only require all-done jobs (and the ones from cirrus-ci). |
The sole reason is to simplify branch protection rules, requiring just these to be passed.
Currently a draft, pending #4374 #4360 merge.