-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go:mod: runtime-spec v1.1.0-rc.1; add docs/spec-conformance.md #3716
go:mod: runtime-spec v1.1.0-rc.1; add docs/spec-conformance.md #3716
Conversation
Let's release runc v1.2.0-rc.1 after merging this |
51582e2
to
fbea8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fbea8cc
to
dd26c41
Compare
Rebased, as #3377 was merged |
7724eb0
to
d1127d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rebased |
d1127d9
to
f41bc0a
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
f41bc0a
to
e412b4e
Compare
Rerebased |
Failure in centos-stream-9 CI:
Hmm, I have absolutely no idea where the "basename" is coming from in this test. Most probably it's from some bashrc on the testing host (in this case we run bash from the host inside the cgroup, see
--norc to work around this, but in general this should not ever happen.
Update: ah, this is centos-stream-9, perhaps something was broken in there. |
Restarted the CI and it is now green |
I've seen this error yesterday too :-/ I completely forgot about it. |
@kolyshkin @thaJeztah Lost your LGTMs after rebasing, could you LGTM again 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM
runc now implements the OCI Runtime Spec v1.1.0-rc.1 for the
linux
platform.The following features are not implemented yet:
SCMP_ARCH_PARISC
SCMP_ARCH_PARISC64
.linux.personality
.linux.resources.cpu.burst
.domainname
.[]mounts.uidMappings
.[]mounts.gidMappings
SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV