-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for umask when exec container #3661
Conversation
this will support update umask when exec container @kolyshkin |
Thanks! Need to fix a linter warning (please use For the test case, something like this should work: diff --git a/tests/integration/umask.bats b/tests/integration/umask.bats
index fe9f9d63..38e8f621 100644
--- a/tests/integration/umask.bats
+++ b/tests/integration/umask.bats
@@ -21,4 +21,9 @@ function teardown() {
[ "$status" -eq 0 ]
# umask 63 decimal = umask 77 octal
[[ "${output}" == *"77"* ]]
+
+ runc exec test_busybox grep '^Umask:' "/proc/self/status"
+ [ "$status" -eq 0 ]
+ # umask 63 decimal = umask 77 octal
+ [[ "${output}" == *"77"* ]] |
@kolyshkin done |
Please check it, thanks @kolyshkin @AkihiroSuda |
done it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but slightly fear this may potentially break some compatibility
I guess we can afford it with 1.2.0. I checked and it looks like crun is supporting umask for exec from the very beginning. |
@Wang-squirrel can you please rebase? |
Signed-off-by: WangXiaoSong <wang.xiaosong1@zte.com.cn>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM
Signed-off-by: Wang-squirrel wang.xiaosong1@zte.com.cn