[1.1] libct/cg/sd/v2: fix ENOENT on cgroup delegation #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
approved these changes
Mar 8, 2022
Apparently, not all files listed in /sys/kernel/cgroup/delegate must exist in every cgroup, so we should ignore ENOENT. Dot not ignore ENOENT on the directory itself though. Change cgroupFilesToChown to not return ".", and refactor it to not do any dynamic slice appending in case we're using the default built-in list of files. Fixes: 35d20c4 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 8c04b98) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
f67cf89 to
9619342
Compare
|
Hmm, apparently the "update with rebase" is working, with all LGTMs left intact, so I have enabled this option for all PRs. See #3407 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3389 to 1.1. Original description follows.
Apparently, not all files listed in
/sys/kernel/cgroup/delegatemustexist in every cgroup, so we should ignore
ENOENT.Dot not ignore
ENOENTon the directory itself though.Change cgroupFilesToChown to not return
., and refactor it to not doany dynamic slice appending in case we're using the default built-in
list of files.
Fixes: 35d20c4