libct/cg/sd/dbus: fix NewDbusConnManager #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that the check of trying to use both rootful and rootless in NewDbusConnManager never worked, as we never set dbusInited to true. Do that. While at it, protect this with the mutex (against the case of two goroutines simultaneously calling NewDbusConnManager). This is a rare call, so taking read-only then read-write mutex does not make sense. Fixes: c7f847e Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed (in cri-o/cri-o@5f97b2f#r646855529)
that the check of trying to use both rootful and rootless
in
NewDbusConnManagernever worked, as we never setdbusInitedto true. 🤦🏻Do that. While at it, protect this with the mutex (against the
case of two goroutines simultaneously calling NewDbusConnManager).
This is a rare call, so taking read-only then read-write mutex does not
make sense.
Fixes: c7f847e
(Practically, this is not an issue as I don't expect this (someone using rootless and rootful at the same time) to happen -- but if the check is there it should at least work)